Support orders without price or quantity #103
Merged
+79
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cancelled orders don't have a price or quantity, which leads to failures when converting from protobuf. This allows missing price and quantities. Signed-off-by: cwasicki <[email protected]>
matthias-wende-frequenz
previously approved these changes
Feb 4, 2025
nhatcher-frequenz
previously approved these changes
Feb 4, 2025
| or order.price.currency == Currency.UNSPECIFIED | ||
| or order.quantity.mw.is_nan() | ||
| ): | ||
| if od.state_detail.state != OrderState.CANCELED: |
There was a problem hiding this comment.
I would flatten these two if statements
Collaborator
Author
There was a problem hiding this comment.
Found that too difficult to read, but changed it now.
RELEASE_NOTES.md
Outdated
|
|
||
| ## Bug Fixes | ||
|
|
||
| * Add support for cancelled orders that do not have a price or quantity. |
There was a problem hiding this comment.
I would treat this as a bug fix, a more accurate description would be:
* Deal correctly with cancelled orders with no price or quantity
Cancelled orders may not have a price or quantity, all other orders must have these set. Signed-off-by: cwasicki <[email protected]>
Signed-off-by: cwasicki <[email protected]>
Signed-off-by: cwasicki <[email protected]>
Signed-off-by: cwasicki <[email protected]>
cwasicki
dismissed stale reviews from nhatcher-frequenz and matthias-wende-frequenz
via
5ccdc6a
github-actions
bot
added
the
part:tests
Signed-off-by: cwasicki <[email protected]>
Collaborator
Author
|
Updated and added test |
nhatcher-frequenz
approved these changes
Feb 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for cancelled orders which do not have the price or quantity field set. Since the order field is still valid for cancelled orders and price and quantity fields are not designed as optional, we set the fields to
NaN.In addition to that the headers of the CLI tool are fixed.